Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24515: Rudder should finish to migrate all techniques when booting instead of stopping on first error #5479

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche VinceMacBuche requested a review from fanf March 15, 2024 18:19
@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the bug_24515/rudder_should_finish_to_migrate_all_techniques_when_booting_instead_of_stopping_on_first_error branch from b795aee to ba2953b Compare March 15, 2024 18:21
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the bug_24515/rudder_should_finish_to_migrate_all_techniques_when_booting_instead_of_stopping_on_first_error branch from ba2953b to 157e508 Compare March 16, 2024 13:56
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5479
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/81642/console)

@VinceMacBuche
Copy link
Member Author

OK, merging this PR

@VinceMacBuche VinceMacBuche merged commit 4a6b62e into Normation:branches/rudder/7.3 Mar 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants