Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24520: Async tests are failing for node certificates #5486

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Mar 18, 2024

https://issues.rudder.io/issues/24520

This is an async test so we use eventually on the expression to match (content of the output stream byte array)

@clarktsiory clarktsiory requested a review from fanf March 18, 2024 13:53
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@fanf
Copy link
Member

fanf commented Mar 18, 2024

Oups, need to be retarget to 7.3

@fanf fanf changed the base branch from branches/rudder/8.1 to branches/rudder/7.3 March 18, 2024 14:06
@clarktsiory clarktsiory force-pushed the bug_24520/async_tests_are_failing_for_node_certificates branch from 154e9b1 to 71358cc Compare March 18, 2024 14:07
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 71358cc into Normation:branches/rudder/7.3 Mar 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants