Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24523: rudderc test should dump the report file path or workdir when a check step fails #5488

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fixes #24523: rudderc test should dump the report file path or workdir when a check step fails #5488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions policies/rudderc/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

// Test file specifications. Do we want several test cases in one file?

use anyhow::{bail, Result};
use anyhow::{bail, Context, Result};
use rudder_commons::{logs::ok_output, PolicyMode, Target};
use serde::{Deserialize, Serialize};
use std::{
Expand Down Expand Up @@ -109,16 +109,15 @@ impl TestCase {
}

pub fn check(&self, dir: &Path, reports_file: &Path, target_dir: &Path) -> Result<()> {
let r = reports_file.canonicalize().unwrap();
for s in &self.check {
s.run(
self.target,
dir,
vec![(
"REPORTS_FILE",
&reports_file.canonicalize().unwrap().to_string_lossy(),
)],
vec![("REPORTS_FILE", &r.clone().to_string_lossy())],
target_dir,
)?;
)
.with_context(|| format!("Reporting file: {}", r.to_string_lossy()))?;
}
Ok(())
}
Expand Down