Fixes #24549: Resizing node tab in group page should stop at header #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
clarktsiory
force-pushed
the
bug_24549/resizing_node_tab_in_group_page_should_stop_at_header
branch
from
2e10002
to
23b8e55
Compare
|
Commit modified |
clarktsiory
force-pushed
the
bug_24549/resizing_node_tab_in_group_page_should_stop_at_header
branch
2 times, most recently
from
95c9d04
to
abac9ad
Compare
|
Commit modified |
|
Commit modified |
clarktsiory
force-pushed
the
bug_24549/resizing_node_tab_in_group_page_should_stop_at_header
branch
from
abac9ad
to
f6d0c0c
Compare
clarktsiory
commented
Mar 21, 2024
Comment on lines
1361
to
1365
| var isResizing = false, | ||
| hasHandle = false, | ||
| hasHandle = $('#drag').length > 0, | ||
| offsetBottom = 250; | ||
|
|
||
| $(function () { |
There was a problem hiding this comment.
when mutating the hasHandle inside the $(function () {}) body, it goes out of scope after execution and gets its old state back, so hasHandle was always false 😓 Damn JS...
VinceMacBuche
approved these changes
Mar 22, 2024
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24549