Fixes #24558: Upmerge removed breaks 8.1 - api acl plugin #5501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
commented
Mar 21, 2024
| @@ -292,6 +292,7 @@ object ApiAuthorization { | |||
| case object RO extends ApiAuthorization { override val kind: ApiAuthorizationKind = ApiAuthorizationKind.RO } | |||
| final case class ACL(acl: List[ApiAclElement]) extends ApiAuthorization { | |||
| override def kind: ApiAuthorizationKind = ApiAuthorizationKind.ACL | |||
| def debugString: String = acl.map(_.display).mkString(";") | |||
VinceMacBuche
approved these changes
Mar 21, 2024
|
PR updated with a new commit |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_24558/upmerge_removed_breaks_8_1_api_acl_plugin
branch
from
4fbbac8
to
dd1eacf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24558
oups