Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24352: Plugin information is too empty when there is no plugin #5506

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Mar 21, 2024

@ElaadF ElaadF requested a review from amousset March 21, 2024 15:52
@ElaadF
Copy link
Member Author

ElaadF commented Mar 21, 2024

Commit modified

@ElaadF ElaadF force-pushed the enh_24352/plugin_information_is_too_empty_when_there_is_no_plugin branch from 51d156f to 455c664 Compare March 21, 2024 15:54
<div class="marker"><span class="glyphicon glyphicon-info-sign"></span></div>
<p>Plugins are managed by the rudder package manager.</p>
<p>
You can consult the list of plugin with the command <b>rudder package list --all</b><br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can consult the list of plugin with the command <b>rudder package list --all</b><br />
You can consult the list of plugins with the command <b>rudder package list --all</b><br />

<p>Plugins are managed by the rudder package manager.</p>
<p>
You can consult the list of plugin with the command <b>rudder package list --all</b><br />
To consult the list of plugin already installed you can use the command <b>rudder package list</b><br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To consult the list of plugin already installed you can use the command <b>rudder package list</b><br />
To consult the list of plugins already installed you can use the command <b>rudder package list</b><br />

To consult the list of plugin already installed you can use the command <b>rudder package list</b><br />
Finally you can install a plugin with the command <b>rudder package install plugin-name</b><br />
</p>
<p>Rudder package manager comes with more command, to consult the help use the command <b>rudder package help</b></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>Rudder package manager comes with more command, to consult the help use the command <b>rudder package help</b></p>
<p>Rudder package manager comes with more commands, to consult the help use the command <b>rudder package help</b></p>

@@ -30,6 +30,16 @@ <h1>Plugins</h1>
</div>
<div class="main-details">
<div class="lift:administration.PluginManagement.display">
<div class="rudder-package-doc callout-fade callout-info">
<div class="marker"><span class="glyphicon glyphicon-info-sign"></span></div>
<p>Plugins are managed by the rudder package manager.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>Plugins are managed by the rudder package manager.</p>
<p>Plugins are managed by the Rudder package manager.</p>

@ElaadF
Copy link
Member Author

ElaadF commented Mar 28, 2024

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5506
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/82421/console)

@ElaadF
Copy link
Member Author

ElaadF commented Mar 28, 2024

OK, squash merging this PR

@ElaadF ElaadF force-pushed the enh_24352/plugin_information_is_too_empty_when_there_is_no_plugin branch from c168e15 to 1bc1128 Compare March 28, 2024 11:15
@ElaadF ElaadF merged commit 1bc1128 into Normation:branches/rudder/7.3 Mar 28, 2024
0 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants