Fixes #24562: When moving an inventory to "received", check if other file for same node uuid exists and delete it #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
amousset
approved these changes
Mar 21, 2024
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…r file for same node uuid exists and delete it
…r file for same node uuid exists and delete it
fanf
force-pushed
the
bug_24562/when_moving_an_inventory_to_received_check_if_other_file_for_same_node_uuid_exists_and_delete_it
branch
from
86ec8a4
to
ef1ff0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24562
Normalize the file name before moving to received folder.
We never fail on the normalization, it seems less risky to have several time similar files in received than an unmatch error for an unforseen case.