Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24419: Persistant tooltip on info icon in methods #5514

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier commented Mar 22, 2024

https://issues.rudder.io/issues/24419

  • All the popovers that were acting as tooltips have been replaced with tooltips
  • All the unnecessary tooltips (e.g. "Clone this method" on the clone button) have been removed
  • Increased number of tooltip cleanings

@@ -143,14 +143,15 @@
createInfoNotification(str)
});
app.ports.clearTooltips.subscribe(function(str) {
console.log("CLEAR");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this log

@RaphaelGauthier RaphaelGauthier force-pushed the bug_24419/persistant_tooltip_on_info_icon_in_methods branch from 7e00e4d to 2190ec1 Compare March 22, 2024 16:27
@RaphaelGauthier
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 8785970 into Normation:branches/rudder/8.1 Mar 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants