Fixes #24583: We should not be able to save a technique with empty enum parameters #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
ElaadF
force-pushed
the
bug_24583/we_should_not_be_able_to_save_a_technique_with_empty_enum_parameters
branch
2 times, most recently
from
d6efa4b
to
39649ab
Compare
|
Commit modified |
|
PR rebased |
ElaadF
force-pushed
the
bug_24583/we_should_not_be_able_to_save_a_technique_with_empty_enum_parameters
branch
from
39649ab
to
3746ebb
Compare
|
Commit modified |
ElaadF
force-pushed
the
bug_24583/we_should_not_be_able_to_save_a_technique_with_empty_enum_parameters
branch
2 times, most recently
from
941ad40
to
c806a81
Compare
|
An enum value may be empty, if the value is not "required" If required is checked, then you have an error |
|
but <3 |
clarktsiory
reviewed
Mar 25, 2024
webapp/sources/rudder/rudder-web/src/main/elm/sources/Editor/ViewTechniqueTabs.elm
Outdated
Show resolved
Hide resolved
|
Commit modified |
ElaadF
force-pushed
the
bug_24583/we_should_not_be_able_to_save_a_technique_with_empty_enum_parameters
branch
from
c806a81
to
303080a
Compare
|
Commit modified |
ElaadF
force-pushed
the
bug_24583/we_should_not_be_able_to_save_a_technique_with_empty_enum_parameters
branch
from
303080a
to
759816e
Compare
clarktsiory
reviewed
Mar 25, 2024
webapp/sources/rudder/rudder-web/src/main/elm/sources/Editor/ViewTechniqueTabs.elm
Outdated
Show resolved
Hide resolved
|
Commit modified |
ElaadF
force-pushed
the
bug_24583/we_should_not_be_able_to_save_a_technique_with_empty_enum_parameters
branch
from
759816e
to
2100e4a
Compare
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 481d9e8
into
Normation:branches/rudder/8.1
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24583
Edit from #5520 (comment)