Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24586: Compilation output tab icon in technique is not aligned #5522

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Mar 22, 2024

https://issues.rudder.io/issues/24586
I changed the icon too, a check mark was misleading since this is error compilation
image

@ElaadF ElaadF requested a review from amousset March 22, 2024 22:01
@ElaadF
Copy link
Member Author

ElaadF commented Mar 22, 2024

Commit modified

@ElaadF ElaadF force-pushed the bug_24586/compilation_output_tab_icon_in_technique_is_not_aligned branch from fadf434 to f6b2a14 Compare March 22, 2024 22:55
@clarktsiory clarktsiory self-requested a review March 25, 2024 09:20
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5522
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/82169/console)

@clarktsiory
Copy link
Contributor

OK, merging this PR

@clarktsiory clarktsiory merged commit 09b9874 into Normation:branches/rudder/8.0 Mar 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants