Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24592: Allow technique id starting with a number #5528

Merged
merged 1 commit into from Mar 25, 2024
Merged

Fixes #24592: Allow technique id starting with a number #5528

merged 1 commit into from Mar 25, 2024

Conversation

amousset
Copy link
Member

@amousset amousset commented Mar 25, 2024 •
edited

https://issues.rudder.io/issues/24592

  • Create a separate type for technique id as the constraints are different
  • Modify the schema accordingly
  • Add a Technique- prefix to all Windows techniques (for consistency, I prefer to avoid a "surprise" prefix in corner cases).

@amousset amousset requested a review from Fdall March 25, 2024 15:27
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5528
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/82211/console)

@amousset
Copy link
Member Author

OK, merging this PR

@amousset amousset merged commit 67fd6ac into Normation:branches/rudder/8.0 Mar 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdall Fdall Fdall approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @Fdall