Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24598: Typo in compliance score tooltip #5534

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fixes #24598: Typo in compliance score tooltip #5534

merged 1 commit into from
Mar 26, 2024

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Mar 26, 2024 •
edited
Loading

https://issues.rudder.io/issues/24598

Should we not change the sentence structure here ? like :

The node is less than 25% compliant
The node is 100% compliant
The Node is at least 75/50/25% compliant

@ElaadF ElaadF requested a review from amousset March 26, 2024 10:07
@ElaadF
Copy link
Member Author

ElaadF commented Mar 26, 2024

Commit modified

@ElaadF ElaadF force-pushed the bug_24598/typo_in_compliance_score_tooltip branch from 5da657a to ba0fe1c Compare March 26, 2024 10:19
@ElaadF
Copy link
Member Author

ElaadF commented Mar 26, 2024

Commit modified

@ElaadF ElaadF force-pushed the bug_24598/typo_in_compliance_score_tooltip branch from ba0fe1c to d6386d4 Compare March 26, 2024 14:35
@ElaadF
Copy link
Member Author

ElaadF commented Mar 26, 2024

PR updated with a new commit

@ElaadF
Copy link
Member Author

ElaadF commented Mar 26, 2024

PR rebased

@ElaadF ElaadF force-pushed the bug_24598/typo_in_compliance_score_tooltip branch from 1740db5 to 439df0a Compare March 26, 2024 14:42
@ElaadF
Copy link
Member Author

ElaadF commented Mar 26, 2024

PR rebased

1 similar comment
@ElaadF
Copy link
Member Author

ElaadF commented Mar 26, 2024

PR rebased

@ElaadF
Copy link
Member Author

ElaadF commented Mar 26, 2024

Commit modified

@ElaadF ElaadF force-pushed the bug_24598/typo_in_compliance_score_tooltip branch from 439df0a to f6adb0a Compare March 26, 2024 15:40
@ElaadF
Copy link
Member Author

ElaadF commented Mar 26, 2024

Commit modified

@ElaadF ElaadF force-pushed the bug_24598/typo_in_compliance_score_tooltip branch from f6adb0a to 2b7a2fd Compare March 26, 2024 15:43
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 117b865 into Normation:branches/rudder/8.1 Mar 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ElaadF @Normation-Quality-Assistant @amousset