You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On backend, it's just a call to the relevant woNodeRepository function, plus some html/ajax to make it works.
I needed to extract the div with security info to make it displayable again after change.
I prefered to rebuild it all than just changing the icon because the key/key status logic is complex and I wanted to use the same logic for displaying (so that nothing change after reload).
Why Administration rights ? Administration is to manage rudder server and here to manage a Node parameter. I know that's a sensitive operation and can understand the will to put it behind walls, but I would have set "Node write"
The api to update a Node, and reset it's key status is behind Node Edit right, (maybe not a good choice, like all edit) but i would have put the same right
This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command: rudder-dev merge https://github.com/Normation/rudder/pull/5547
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/83105/console)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fanf
force-pushed
the
enh_12791/have_a_reset_keys_button_on_the_node_screen
branch
from
https://issues.rudder.io/issues/12791
Add a button to reset the key status if:
On backend, it's just a call to the relevant
woNodeRepositoryfunction, plus some html/ajax to make it works.I needed to extract the div with security info to make it displayable again after change.
I prefered to rebuild it all than just changing the icon because the key/key status logic is complex and I wanted to use the same logic for displaying (so that nothing change after reload).
change-key-status.webm