Fix new warnings introducted by scala 2.13.13 and -Xsource:3-cross option #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaechler
force-pushed
the
xsource-3-cross
branch
4 times, most recently
from
24fdf1e
to
fcd759b
Compare
…tion
* boolean arguments need to be passed by name
* variable shadowing is now a warning
* case class constructor reference requires a `.apply`
In scala 3.4, private[this] is now useless, it has been deprecated
mbaechler
force-pushed
the
xsource-3-cross
branch
from
fcd759b
to
de51768
Compare
… catchall for future values
mbaechler
force-pushed
the
xsource-3-cross
branch
from
a9c959b
to
a2ece2a
Compare
… it requires manual definition now
…private scope for the enclosing type now
mbaechler
force-pushed
the
xsource-3-cross
branch
from
a2ece2a
to
4dbb145
Compare
fanf
pushed a commit
to fanf/rudder
that referenced
this pull request
Apr 30, 2024
This is the port of Normation#5548
|
I'm closing this one since it was merged with #5639 - it remains only the first commit about pom change, that will need to go elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits for details
I suggest to refrain from merging theXsource:3-crosscompilation flag until Intellij handles it properly ( see https://youtrack.jetbrains.com/issue/SCL-22204/IDEA-doesnt-recognize-Xsource3-cross-option ).Requires intellij scala plugin 2024.1.20
Updated: I split the change of scala compiler and Xsource:3-cross flag in a separated commit, so everything else can be merged.