Fixes #24634: API to find usage of a node property in Directives

[ElaadF]

https://issues.rudder.io/issues/24634

Pagination

Preamble

This PR has been made as a side project on my free time. I don't have a deadline, and I don't know when it will be done. It's started as a small test to see if this was not too much painful to develop, but it ends up being a little bit more polish that I was expecting. Feel free to comment, add remarks and review the work done, I will do my best to address them ASAP on my free time.

Goal

This feature aim to add discoverability on node's properties. Nodes' properties are an essential part of Rudder workflow, it's seem important to see if a property used or not and if yes to be able to visit the object that is using this property. I'm often

Journal

16/04/2024 - 92ab292 3e85145

• Beautify the search icon, to make it consistent with the edit buttons, only appear when the table line is hovered
• Make the find usage API private
• Next step verify that a user with no required read rights doesn't have access to this feature

06/04/2024 - 89348fd

• Pagination is added in the UI (see the gif) it was a bit tedious, the hardest part was to make the table scrollable and contains inside the modal, I have some ugly CSS to force the max-height and the rows width but... it works, that's all I need
• Next step is to beautify the search button to display it only on hover

05/04/2024

• I have been able to set up API and service testing, the logics are a bit redundant, but the API is here to make sure that it is responding as expecting, prevent breaking the UI. In the service testing, we can see what the service take into account for detecting a property's usage.
• Next step is probably adding pagination to the UI, because some user can have a lot of Technique and Directive, we have to be able to scale in terms of UI for the table since this is a tiny popup.
  I'm also concerned about the performance issues to parse every directive's parameter and technique's parameter on large instance, need more reflection on this subject, later.

04/04/2024 - fe6096f

• The feature is working as expected, I have been able to add API tests, but I have some issue to make working my service tests, apparently test_find_property_usage_in_technique is not initialized, making some other tests (who rely on NodeConfig) fail, and I cannot figure it why for the moment.

Todos :

• Add pagination 89348fd
• Unit testing 83ae097
• Beautify find usage button 3e85145
• Make the API private 92ab292
• Verify Read access requirements for URL redirection and find usage
• Load testing
• Refactoring toJson

[ElaadF]

PR updated with a new commit

[ElaadF]

PR updated with a new commit

[ElaadF]

PR updated with a new commit

[ElaadF]

PR updated with a new commit

[ElaadF]

Commit modified

[ElaadF]

PR rebased

[ElaadF]

PR rebased

[ElaadF]

PR updated with a new commit

[ElaadF]

Commit modified

[ElaadF]

Commit modified

[ElaadF]

PR updated with a new commit

[ElaadF]

Commit modified

[ElaadF]

Commit modified

[ElaadF]

Commit modified

[ElaadF]

Commit modified

[ElaadF]

Commit modified

[amousset]

I think we somehow need to use the parsed version (but I don't have any idea how/where it is available)

[ElaadF]

If I remember, we have indeed a parsed version, and it is basically the same process, thanks for the feedback, I will try to modify that

[fanf]

Cool, looks promising!

Could you add tests, if possible :

• at least at api level with yaml request / query output)
• if possible at service unit test level too, so that it's easier to have an anti regression specification

[ElaadF]

PR updated with a new commit

[ElaadF]

PR updated with a new commit

[ElaadF]

Commit modified

[ElaadF]

PR updated with a new commit

[ElaadF]

PR updated with a new commit

[ElaadF]

PR updated with a new commit

[ElaadF]

PR rebased

[ElaadF]

PR rebased