Fixes #24637: Improvements on score: F score, rework tooltip, improve messages #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
reviewed
Mar 29, 2024
| @@ -57,6 +57,7 @@ object ScoreValue extends Enum[ScoreValue] { | |||
| case object C extends ScoreValue { val value = "C" } | |||
| case object D extends ScoreValue { val value = "D" } | |||
| case object E extends ScoreValue { val value = "E" } | |||
| case object F extends ScoreValue { val value = "F" } | |||
VinceMacBuche
force-pushed
the
bug_24637/improvements_on_score_f_score_rework_tooltip_improve_messages
branch
from
eead7eb
to
dffb75a
Compare
|
Commit modified |
fanf
force-pushed
the
bug_24637/improvements_on_score_f_score_rework_tooltip_improve_messages
branch
from
dffb75a
to
fd2422c
Compare
fanf
reviewed
Apr 2, 2024
| @@ -456,7 +456,7 @@ CREATE TABLE NodeFacts ( | |||
| ); | |||
|
|
|||
|
|
|||
| CREATE TYPE score AS enum ('A', 'B', 'C', 'D', 'E'); | |||
| CREATE TYPE score AS enum ('A', 'B', 'C', 'D', 'E', 'F', 'X'); | |||
There was a problem hiding this comment.
This leads to SQL errors for people with the beta2 since there is no migration. Pondering if it's important, not sure, but we should at least add in release notes:
"if you upgrade from a beta version, you need to do:
rudder=> ALTER TYPE score ADD VALUE 'F';
ALTER TYPE
rudder=> ALTER TYPE score ADD VALUE 'X';
ALTER TYPE
rudder=>
There was a problem hiding this comment.
We don't support update between beta, we never did nor we want to support it
clarktsiory
reviewed
Apr 2, 2024
...p/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/score/ComplianceScore.scala
Outdated
Show resolved
Hide resolved
…/rudder/score/ComplianceScore.scala Co-authored-by: Clark Andrianasolo <65616064+clarktsiory@users.noreply.github.com>
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 152a4a6
into
Normation:branches/rudder/8.1
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24637