Fixes #24734: Remove System compliance from Score #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Apr 17, 2024
| cp = complianceWithoutSystem.compliance.computePercent() | ||
| event = ComplianceScoreEvent(nodeId, cp) | ||
| _ <- scoreServiceManager.handleEvent(event) | ||
| } yield () |
There was a problem hiding this comment.
since it's exactly the same code at two places and it's becoming non trivial, can you factor-it out somewhere ?
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_24734/remove_system_compliance_from_score
branch
from
4494b6d
to
3ed979d
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_24734/remove_system_compliance_from_score
branch
from
3ed979d
to
c3b3b57
Compare
fanf
reviewed
Apr 17, 2024
| import net.liftweb.common.Box | ||
| import net.liftweb.common.Full | ||
| import org.joda.time.DateTime | ||
| import org.junit.runner.RunWith | ||
| import org.specs2.mutable.* | ||
| import org.specs2.mutable._ |
There was a problem hiding this comment.
Seems like your intellij doesn't like scala 3 syntax :)
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_24734/remove_system_compliance_from_score
branch
from
c3b3b57
to
c41676e
Compare
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 9734452
into
Normation:branches/rudder/8.1
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24734