-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #24722: Update gulp related js dependencies #5606
Fixes #24722: Update gulp related js dependencies #5606
Conversation
PR updated with a new commit |
@@ -133,7 +149,7 @@ function vendor_js(cb) { | |||
}; | |||
|
|||
function css(cb) { | |||
src(paths.css.src) | |||
src(paths.css.src, { encoding: false }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add this option to make ionicons and fontawesome work.
Gulp 5 stream encoding is now set to UTF-8 by default, which is not compatible with these icon libs :
Our streams now default to UTF-8 encoding. Previously, our streams took whatever data was emitted without considering any encoding. However, in this release, we resolved a 10 year old issue to support custom encodings and we default these to UTF-8. Most usage of gulp won’t need to change anything, but certain plugins may produce non-UTF-8 output and you’ll need to set
{ encoding: false }
on your gulp streams.
Fixes #24722: Update gulp related js dependencies
PR rebased |
2b4ff63
to
205c9db
Compare
This PR is not mergeable to upper versions. |
https://issues.rudder.io/issues/24722
Only two js dependencies have been updated in this PR :
The gulpfile.js file (now gulpfile.mjs) has been converted into an Ecmascript module , so that the new version of del package can be imported as a module (that package has become an esm-only package in this new version).
gulp-cli
supports ESM so this change has no side effect.This implies a few changes to the file :