Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24744: Score explanation should not move score element when text is too long #5612

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Apr 17, 2024

@RaphaelGauthier
Copy link
Member

I would fix this issue in another way, by aligning the "explanation" section on the left and ensuring that its width does not change according to its content.

  • remove the css class .flex-grow-1 on the div.score-breakdown
  • add a white-space : nowrap; in the css rule .compliance-score label (rudder-compliance.scss:251) :
.compliance-score label {
  ...
  white-space: nowrap;
}

@ElaadF
Copy link
Member Author

ElaadF commented Apr 18, 2024

PR updated with a new commit

1 similar comment
@ElaadF
Copy link
Member Author

ElaadF commented Apr 18, 2024

PR updated with a new commit

@ElaadF
Copy link
Member Author

ElaadF commented Apr 18, 2024

explnation

@ElaadF
Copy link
Member Author

ElaadF commented Apr 18, 2024

PR rebased

@ElaadF ElaadF force-pushed the bug_24744/score_explanation_should_not_move_score_element_when_text_is_too_long branch from 36efaee to 5e8caab Compare April 18, 2024 12:35
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit efc3b85 into Normation:branches/rudder/8.1 Apr 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants