Fixes #24749: Disabled LDAP users can still login and use Rudder #5615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
clarktsiory
force-pushed
the
bug_24749/disabled_ldap_users_can_still_login_and_use_rudder
branch
from
1e4e7ab
to
f6e2252
Compare
clarktsiory
merged commit f6e2252
into
Normation:branches/rudder/7.3
8 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24749
Authentication validation should be the same as with "file" or "OIDC" : call
loadUserByUsername, which takes into account the user status from the database to refuse authentication of disabled users.There is some slight change in behavior : for LDAP users which were not found in the "users.xml" file we proceeded with a successful login but with no rights. Now, we fail at the login step. It is more consistent with the behavior for disabled users from "file" or "OIDC" backends.