Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24757: Unable to log in - Server error #5618

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Apr 19, 2024

https://issues.rudder.io/issues/24757

The tenants column in the database is nullable (it is null especially when server is upgraded from 8.0 to 8.1).
Changing the case class changes the doobie Meta and now the null values before migration will not throw an error

@clarktsiory clarktsiory requested a review from fanf April 19, 2024 14:23
@clarktsiory
Copy link
Contributor Author

Commit modified

@clarktsiory clarktsiory force-pushed the bug_24757/unable_to_log_in_server_error branch from b985f36 to 8ae5414 Compare April 19, 2024 14:45
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 8ae5414 into Normation:branches/rudder/8.1 Apr 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants