Fixes #24817: When there are more nodes than supported by licenses, no logs in webapp states it #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o logs in webapp states it
fanf
commented
May 2, 2024
| case Some(i) => s"'${i.softwareId}' " | ||
| case None => "" | ||
| } | ||
| ApplicationLoggerPure.Plugin.logEffect.warn(s"Plugin ${name}is disabled: ${reason}") |
There was a problem hiding this comment.
this will be outputed each time a limited feature is accessed. It may spam logs, but it seems more important to have the message if number of nodes grow out of bound after start
VinceMacBuche
approved these changes
May 2, 2024
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24817
Successfully where to add the check to be useful.
Now, the log looks like that at start:
At at run time, when a limited feature is triggered: