Fixes #24832: Migrate rudder-web to zio-json #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
commented
May 3, 2024
Comment on lines
-187
to
-188
| implicit val formats = DefaultFormats | ||
| val serverList = parse(jsonArrayOfIds).extract[List[String]].map(x => NodeId(x)) |
There was a problem hiding this comment.
parse could throw an exception but we already have an alter on user-side when the list is empty, so we can do with an empty list
|
PR updated with a new commit |
fanf
approved these changes
May 3, 2024
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
clarktsiory
force-pushed
the
arch_24832/migrate_rudder_web_to_zio_json
branch
from
c21a380
to
4507f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24832