Fixes #24844: Software updates need to be special cased for performance in nodefact #5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
May 15, 2024
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 9b64523
into
Normation:branches/rudder/8.1
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24844
I think there is literally nothing surprising in that PR. We just move
SoftwareUpdateinMinimalNodeFactInterface, we change thesamemethods, we remove where compiler say to remove.And we just change
LdapStorageto getSoftwareUpdatein addition to other info from node inventory LDAP entry, and we make possible to add it inNodeFact.fromCompatin the case where we didn't had the whole inventory.