Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24834: When we save an API Token, the UI is grayed out #5663

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier commented May 15, 2024

https://issues.rudder.io/issues/24834

I had to replace the use of bootstrap attributes with a "hard-coded" display of modals in Elm. + I've made the content of the modal scrollable, so that the height of the modal doesn't exceed the height of the screen.

@clarktsiory
Copy link
Contributor

clarktsiory commented May 15, 2024

LGTM, we are no longer stuck with the modal now.

But something weird happens with "static backdrop" modal, the behavior is different when clicking outside of the modal content to close it. For example :

  • I create a token, and click on the "gray" area to close it
  • I attempt to create another one but when I click on the creation button, there is a console error and I have to refresh the page to make it disappear :
    Screenshot from 2024-05-15 10-31-29

The same error also occurs when just attempting to regenerate more than one token.
I think it has to do with our Elm modal states...

@RaphaelGauthier
Copy link
Member Author

PR updated with a new commit

1 similar comment
@RaphaelGauthier
Copy link
Member Author

PR updated with a new commit

Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, that's great, it works like a charm

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5663
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/84729/console)

@RaphaelGauthier
Copy link
Member Author

OK, squash merging this PR

@RaphaelGauthier RaphaelGauthier force-pushed the bug_24834/when_we_save_an_api_token_the_ui_is_grayed_out branch from 8c63972 to 6d3506f Compare May 22, 2024 08:41
@RaphaelGauthier RaphaelGauthier merged commit 6d3506f into Normation:branches/rudder/8.1 May 22, 2024
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants