Fixes #24827: When we have a user without administrator role, the menu "Utilities" exist but leads to a 404 #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
May 16, 2024
| ) / | ||
| "secure" / "utilities" / "index" | ||
| >> LocGroup("utilitiesGroup") | ||
| >> TestAccess(() => userIsAllowed("/secure/index", AuthorizationType.Administration.Read))).submenus( |
There was a problem hiding this comment.
doesn't that will lock-out validator/etc who are not admin_read from accessing the change request validation screen ?
There was a problem hiding this comment.
I think it should only be the removal of Technique Read rights, i think it was there when techique editor was below Utilities, a looooong time ago
ElaadF
force-pushed
the
bug_24827/when_we_have_a_user_without_administrator_role_the_menu_utilities_exist_but_leads_to_a_404
branch
from
88cc043
to
296be8f
Compare
Fixes #24827: When we have a user without administrator role, the menu \"Utilities\" exist but leads to a 404
ElaadF
force-pushed
the
bug_24827/when_we_have_a_user_without_administrator_role_the_menu_utilities_exist_but_leads_to_a_404
branch
from
296be8f
to
a960f63
Compare
|
PR updated with a new commit |
Fixes #24827: When we have a user without administrator role, the menu \"Utilities\" exist but leads to a 404
|
PR updated with a new commit |
| >> TestAccess(() => { | ||
| userIsAllowed( | ||
| "/secure/index", | ||
| AuthorizationType.Administration.Read, |
There was a problem hiding this comment.
You still need to have workflow enabled checked. the menu should not appaear if workflow enabled is false and we don't have administrator Read. You'll still have the 404 in this case
This pr should only be removal of Technique.Read right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24827
totowithtechnique_allright