Fixes #24907: The list of plugin in info API is always empty #5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
approved these changes
May 23, 2024
| @@ -5,7 +5,7 @@ import zio.IO | |||
| * .fail and .succeed were removed in RC18 | |||
| */ | |||
| object syntax { | |||
| implicit class ToZio[A](a: A) { | |||
| implicit class ToZio[A](a: => A) { | |||
There was a problem hiding this comment.
It looks legit, but it doesn't seem to fix the issue, however doing a I had to re-install the ZIO.succeed(...) explicitly works 🤯utils project locally, it works !
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit eef9a4e
into
Normation:branches/rudder/7.3
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24907
So, at some point
ZIOchanged implementation ofZIO.succeedto make its parameter call by name, which was not reflected in our syntax add-on, which means that we were capturing the result of the computation and not a real effect.