Fixes #24472: We should rework the targets rules page when we create a directive #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
approved these changes
Jun 10, 2024
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
RaphaelGauthier
merged commit d053473
into
Normation:branches/rudder/8.0
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24472
I think this is the simplest solution for bringing the filters back on the target rules (starting with the search bar), while waiting for this interface to be completely rewritten in Elm.
I removed all the dead code linked to the angular application that managed the filters, and replaced it with a simple javascript function, adding an onkeyup event to the search input :