Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5225: allows to use ${rudder.node.env.VAR} syntax to get env variable in directives #572

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 8, 2014

The main idea is to add NodeInventory in the context of rudder variable interpretation.

The big problem is that doing so, we need to load all node inventories before hand, perhaps for nothing.

So we need to check the time and space take by that approach on a non trivial node set.
That pull request should wait that test result before being merged.

@ncharles
Copy link
Member

This looks good. Could you check that it does not use too much memory ?

@ncharles
Copy link
Member

I tested it with a limited test set of 50 nodes
From this limited test, i gathered that:

  • memory use does not seem different
  • fetching node information is about 200-250 ms slower (so 5 ms per inventory it seems)

I would need to test with more nodes to confirm these data

@fanf
Copy link
Member Author

fanf commented Jul 18, 2014

The feature was F-review.
It is really low impact and needed for test by some user, so could be merge asap.

ncharles added a commit that referenced this pull request Jul 19, 2014
…_envVar_as_directive_variables

Fixes #5225: allows to use ${rudder.node.env.VAR} syntax to get env variable in directives
@ncharles ncharles merged commit 9c2cd77 into Normation:master Jul 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants