Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24789: Archive API for import/export doesn't know about technique #5747

Open
wants to merge 4 commits into
base: branches/rudder/7.3
Choose a base branch
from

Conversation

fanf
Copy link
Member

@fanf fanf commented Jun 24, 2024

https://issues.rudder.io/issues/24789

This PR introduces import and export of categories for technique.
It add a new file descriptors for them, category.json which mimics category.xml but in JSON for consistency with other file format in archive.
Since category information where not updatable by API (internal or rest) up until now, I needed to also add the relevant logic to actually save changes in `/var/rudder/configuration-repository

@fanf fanf requested a review from clarktsiory June 24, 2024 13:20
@fanf
Copy link
Member Author

fanf commented Jun 24, 2024

PR updated with a new commit

1 similar comment
@fanf
Copy link
Member Author

fanf commented Jun 24, 2024

PR updated with a new commit

@fanf fanf force-pushed the bug_24789/archive_api_for_import_export_doesn_t_know_about_technique_or_rule_categories branch from 74a1f1d to dbeea9a Compare June 24, 2024 14:00
@fanf
Copy link
Member Author

fanf commented Jun 26, 2024

There's a test in error on CI that I don't seem to have locally, it needs a new pass of work:

[2024-06-26T12:22:30.325Z] Tests in error: 

[2024-06-26T12:22:30.325Z]   The test lib should::save a category should::create a new file and commit if the category
does not exist(com.normation.cfclerk.services.JGitRepositoryTest): Chained(error when committing technique 
category 'techniques/systemSettings/myNewCategory/category.xml',SystemError(An error 
occurred,java.nio.file.FileSystemException: /tmp/test-jgit-2024-06-26T14:22:13.809+02:00/techniques/systemSettings/
myNewCategory: Operation not permitted))

[2024-06-26T12:22:30.326Z]   The test lib should::save a category should::does nothing when the category already 
exsits(com.normation.cfclerk.services.JGitRepositoryTest): Chained(error when committing technique category 
'techniques/systemSettings/myNewCategory/category.xml',SystemError(An error 
occurred,java.nio.file.FileSystemException: /tmp/test-jgit-2024-06-26T14:22:13.809+02:00/techniques/systemSettings/
myNewCategory: Operation not permitted))

fanf added 2 commits July 4, 2024 18:14
Fixes #24789: Archive API for import/export doesn't know about technique
@fanf
Copy link
Member Author

fanf commented Jul 12, 2024

PR updated with a new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant