Fixes #25032: Use Content-Security-Policy strict headers in utilities pages #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
clarktsiory
force-pushed
the
bug_25032/use_content_security_policy_strict_headers_in_web_pages
branch
from
1737e05
to
c2c3241
Compare
fanf
reviewed
Jul 8, 2024
| OnLoad( | ||
| JsRaw( | ||
| """enableIfNonEmpty("%s", "%s");$("#%s").prop("disabled",true);""" | ||
| .format(archiveDateSelectId, restoreButtonId, restoreButtonId) |
There was a problem hiding this comment.
why keeping that format ? Interpolation wouldn't be clearer ?
fanf
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
It does the job, and the explicit control is good during migration.
But it will be very easy to forget, so we should try the opposite in next version:
- create a tag that disable csp checking
- put it on content that breaks with csp checking only (ie, enabled by default).
Given there is a bunch of other things to test in that version I think we're too late to do it now, but it can be done as one of the first step of 8.3 (and then use 8.3 dev cycle to add the "without-csp" tag where it is needed)
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 6d79135
into
Normation:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/25032
data-lift="with-enabled-csp"to include in every HTML page for which to enforce strict-CSP