Fixes #5434: change the frequency of agent per agent #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def json = { | ||
|
|
||
| val overrideValue = overrides.map(_.toString).getOrElse("null") |
There was a problem hiding this comment.
using the null in javascript is """"""""" like """"""""" (note the quote) is like using an option type.
I use it to denote that override is not relevant ... I also could use undefined, but null is more acceted as "property has no value"
There was a problem hiding this comment.
ok, thanks for the explaination
VinceMacBuche
force-pushed
the
ust_5293/dev_5434_frequencey_per_node
branch
from
6f6829e
to
8394338
Compare
| @@ -82,6 +86,8 @@ object DisplayNode extends Loggable { | |||
| private[this] val uuidGen = RudderConfig.stringUuidGenerator | |||
| private[this] val nodeInfoService = RudderConfig.nodeInfoService | |||
|
|
|||
| private[this] val nodeRepo = RudderConfig.woNodeRepository | |||
|
|
|||
There was a problem hiding this comment.
why this change ? is it used somewhere ?
VinceMacBuche
force-pushed
the
ust_5293/dev_5434_frequencey_per_node
branch
from
8394338
to
ed9c57c
Compare
VinceMacBuche
force-pushed
the
ust_5293/dev_5434_frequencey_per_node
branch
from
ed9c57c
to
2f80453
Compare
ncharles
added a commit
that referenced
this pull request
Oct 31, 2014
…ey_per_node Fixes #5434: change the frequency of agent per agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.