Fixes #5830: Use technique updates to enable/disable active techniques #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
ust_5670/impl_5830/auto_enable_new_techniques
branch
from
d4f7554
to
913af55
Compare
| <version>{version.toString}</version> | ||
| </modifiedTechnique> | ||
| def buildDetails(techniqueMods: Map[TechniqueName, TechniquesLibraryUpdateType]) : NodeSeq = EventLog.withContent { | ||
| <reloadTechniqueLibrary fileFormat={Constants.XML_CURRENT_FILE_FORMAT.toString}>{ |
There was a problem hiding this comment.
hum, if the format changes, we should increase the XML_CURRENT_FILE_FORMAT, and add a migration script. Shan't we ?
There was a problem hiding this comment.
Done, see update and Normation/rudder-packages#535
fanf
force-pushed
the
ust_5670/impl_5830/auto_enable_new_techniques
branch
from
913af55
to
91eb70e
Compare
|
|
||
|
|
||
| /** | ||
| * Migrate an event log from fileFormat 4 to 5 |
fanf
force-pushed
the
ust_5670/impl_5830/auto_enable_new_techniques
branch
from
91eb70e
to
28f3456
Compare
| * We don't use values from | ||
| * com.normation.rudder.domain.eventlog.*EventType | ||
| * so that if they change in the future, the migration | ||
| * from 2.3 to 2.5 is still OK. |
fanf
force-pushed
the
ust_5670/impl_5830/auto_enable_new_techniques
branch
from
28f3456
to
8dab262
Compare
|
ok, looks good to me |
fanf
force-pushed
the
ust_5670/impl_5830/auto_enable_new_techniques
branch
from
8dab262
to
31f7828
Compare
ncharles
added a commit
that referenced
this pull request
Nov 26, 2014
…techniques Fixes #5830: Use technique updates to enable/disable active techniques
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.