Fixes #5843: Add user defined (via API) node properties #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
ust_5506/impl_5843/add_node_property_key_value_pair
branch
from
d8ee35b
to
2e75b81
Compare
fanf
force-pushed
the
ust_5506/impl_5843/add_node_property_key_value_pair
branch
from
2e75b81
to
e154e33
Compare
| , isBroken : Boolean | ||
| , isSystem : Boolean | ||
| , isPolicyServer : Boolean | ||
| , creationDate : DateTime |
There was a problem hiding this comment.
why to you add the creationDate ?
There was a problem hiding this comment.
To be able to have it in display where we don't need nodeInfo (because we also have inventory)
|
looks ok, aside from the few questions which I would like adressed |
ncharles
added a commit
that referenced
this pull request
Nov 28, 2014
…y_key_value_pair Fixes #5843: Add user defined (via API) node properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.