Fixes #5778: correct API with JSON parameters for directives creation&up... #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… creation&update
| private[this] def extractJsonDirectiveParam (json: JValue ): Box[Map[String,Seq[String]]] = { | ||
| json \\ "parameters" match { | ||
| case x@JObject(_) => parseSectionVal(x).map(SectionVal.toMapVariables(_)) | ||
| case _ => Failure(s"Not a good value for parameter ") |
There was a problem hiding this comment.
shouldn't you tell which one a bad value for parameter ?
|
Why is this change only in branch 3.0 ? from what I understood of the ticket, it is a bug existing in current version of the API, isn't it ? |
| @@ -569,9 +574,11 @@ case class RestExtractorService ( | |||
| longDescription <- extractOneValueJson(json, "longDescription")() | |||
| enabled <- extractOneValueJson(json, "enabled")( convertToBoolean) | |||
| priority <- extractOneValueJson(json, "priority")(convertToInt) | |||
| parameters <- extractOneValueJson(json, "parameters")(convertToDirectiveParam) | |||
| parameters <- extractJsonDirectiveParam(json) | |||
There was a problem hiding this comment.
what happens if we try to create a directive with no parameter, because the technique isn't expecting any ?
There was a problem hiding this comment.
Good question, it should be possible to do so.
|
That PR is not targetting the correct branch. Closing it. |
|
New PR: #707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.