Fixes #5977: Add asycnhronous data for event logs table #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
force-pushed
the
bug_5977/add_asynchronous_data_to_event_logs_table
branch
from
170cdce
to
4f6e84d
Compare
| refreshEvents() match { | ||
| case Full(events) => | ||
| val lines = JsTableData(events.map(EventLogLine(_)).toList) | ||
| logger.info("yolo") |
There was a problem hiding this comment.
But you can't say that this statement is not true
|
Appart from that, everything is OK and you can self-merge as soon as it's removed. Really nice :) |
VinceMacBuche
force-pushed
the
bug_5977/add_asynchronous_data_to_event_logs_table
branch
from
4f6e84d
to
e48e03b
Compare
VinceMacBuche
added a commit
that referenced
this pull request
Dec 11, 2014
…data_to_event_logs_table Fixes #5977: Add asycnhronous data for event logs table
VinceMacBuche
deleted the
bug_5977/add_asynchronous_data_to_event_logs_table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.