Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 5986/eventlogs to track hearbeat change on node are missing #725

Conversation

fanf
Copy link
Member

@fanf fanf commented Dec 16, 2014

No description provided.

@fanf fanf force-pushed the bug_5986/eventlogs_to_track_hearbeat_change_on_node_are_missing branch 2 times, most recently from ccc7649 to 646b104 Compare December 16, 2014 11:04
) extends WoNodeRepository with Loggable {
repo =>

/**
* Change the configuration of agent run pertion for the given node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pertion ? period maybe ?

@ncharles
Copy link
Member

Ok, this is a pretty large change, and i'm amazed by the amount of dead code there was

Could you adress the two small remarks, rebase, and then self merge ?
Thank you !

@fanf
Copy link
Member Author

fanf commented Dec 17, 2014

ok

@fanf fanf force-pushed the bug_5986/eventlogs_to_track_hearbeat_change_on_node_are_missing branch from 646b104 to ea16f60 Compare December 17, 2014 12:02
fanf added a commit that referenced this pull request Dec 17, 2014
…t_change_on_node_are_missing

Bug 5986/eventlogs to track hearbeat change on node are missing
@fanf fanf merged commit a1e64d3 into Normation:branches/rudder/3.0 Dec 17, 2014
@fanf fanf deleted the bug_5986/eventlogs_to_track_hearbeat_change_on_node_are_missing branch March 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants