Fixes #6260: Cannot apply a Directive to all visible Rules #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated |
VinceMacBuche
force-pushed
the
bug_6260/cannot_apply_a_directive_to_all_visible_rules
branch
from
9164ff5
to
c28342b
Compare
|
PR updated |
VinceMacBuche
force-pushed
the
bug_6260/cannot_apply_a_directive_to_all_visible_rules
branch
from
c28342b
to
afc63e8
Compare
|
PR updated |
VinceMacBuche
force-pushed
the
bug_6260/cannot_apply_a_directive_to_all_visible_rules
branch
from
afc63e8
to
b1ddce6
Compare
| val msg = s"Error while trying to apply directive ${directiveApp.directive.id.value} on visible Rules" | ||
| logger.error(s"$msg, cause is: ${e.getMessage()}") | ||
| logger.debug(s"Error details:") | ||
| e.getStackTrace().foreach(st => logger.debug(st)) |
There was a problem hiding this comment.
You should juste use: logger.debug(s"Error details:", e) - it will duplicates the exception first line, but it's ok since the log will be in debug and so, when debugging it is easier to understand the whole exception.
|
PR updated |
VinceMacBuche
force-pushed
the
bug_6260/cannot_apply_a_directive_to_all_visible_rules
branch
from
b1ddce6
to
9d5db56
Compare
fanf
added a commit
that referenced
this pull request
Feb 12, 2015
…rective_to_all_visible_rules Fixes #6260: Cannot apply a Directive to all visible Rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/6260