Bug 6519/don t increase serial when adding nodes #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to be merge after #849 |
…mic the behaviour of deletion of nodes)
ncharles
force-pushed
the
bug_6519/don_t_increase_serial_when_adding_nodes
branch
from
b28bfa3
to
9201c28
Compare
|
It's ok with me. good explanation and motivational justification |
fanf
added a commit
that referenced
this pull request
Apr 20, 2015
…when_adding_nodes Bug 6519/don t increase serial when adding nodes
| logger.trace("`-> No node configuration cache availabe for that node") | ||
| targetConfig.policyDrafts.map( _.ruleId ).toSet | ||
| Set[RuleId]() |
There was a problem hiding this comment.
ok, in case of clear cache, this doesn't do as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rational here is to prevent undue serial upgrade when adding a node in a rule.
The serial change should be only for "change" of config
The huge benefit of that is that we don't lose compliance info of the rule when accepting node
The second great benefit is that promise generation is faster: less change
This picture show the rule screen after having accepted a node
