Issue #6137: add an API for compliance by node or rule #868
Conversation
fanf
force-pushed
the
ust_6137/create_compliance_api
branch
from
7569e2e
to
8537894
Compare
| object JsonCompliance { | ||
|
|
||
|
|
||
| implicit class JsonbyRuleCompliance(rule: ByRuleRuleCompliance) { |
There was a problem hiding this comment.
Interesting, I compared with how we display compliance for a Rule in the webui
In the web ui, We do:
- Directives
- Components
- Values
- Components
And here, in the API, we do
- Directives
- Components
- Nodes
- Values
- Nodes
- Components
Do you think we should add the "Node" level also in the webui, in a near future ? (3.2 ?)
There was a problem hiding this comment.
I'm not sur, because in the UI, you have the two view availables, so having nodes and value merge may not be a limitation.
On the other hand, we could have a way to see which nodes are in error for a given value (and only errors), what could be nice
There was a problem hiding this comment.
To me it's clearly missing on the webapp, you can't know which nodes is wrong on a component, until you go to the last level of each nodes
The other way that could be done is:
- Directives
- Components
- Values
- Nodes
- Values
- Components
There was a problem hiding this comment.
This other way feels less logical, because a value may be node dependant (ex: file path depending of the hostname), and the error are by value and by node (node foo reported error bla on value val).
fanf
force-pushed
the
ust_6137/create_compliance_api
branch
2 times, most recently
from
8a2a893
to
c5ae078
Compare
fanf
force-pushed
the
ust_6137/create_compliance_api
branch
from
c5ae078
to
c5087b4
Compare
|
Great feature for the web api ! Don't forget to add the API documentation !! |
Issue #6137: add an API for compliance by node or rule
See http://www.rudder-project.org/redmine/issues/6137 for details about what is added