Fixes #7375: Add an option in the web interface to completely disable reporting #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val allModes = ComplianceModeName.allModes.map(_.name).mkString("(", "|", ")") | ||
| allModes | ||
| } | ||
| , errorMsg = s"Forbiden value, only 'full-compliance' and 'changes-only' are authorized" |
There was a problem hiding this comment.
the error message seems incomplete - reports-disabled should be authorized
|
PR updated |
VinceMacBuche
force-pushed
the
ust_7375/add_an_option_in_the_web_interface_to_completely_disable_reporting
branch
from
3199e0e
to
244ee60
Compare
|
|
||
| object ChangesOnly { | ||
| final case object ChangesOnly extends ComplianceModeName { |
There was a problem hiding this comment.
no need for final on object, they are already (you can look at the bytecode for that, or it's certainly specified somewhere in some scala spec). But you can let it here, I does no arm.
|
PR updated |
VinceMacBuche
force-pushed
the
ust_7375/add_an_option_in_the_web_interface_to_completely_disable_reporting
branch
from
244ee60
to
2b8e5a2
Compare
|
Still some things to do (last @fanf remark) And also waiting new text about the new mode in the webapp should be ok verrryyyy soon |
|
PR updated |
VinceMacBuche
force-pushed
the
ust_7375/add_an_option_in_the_web_interface_to_completely_disable_reporting
branch
from
2b8e5a2
to
1b3f4c5
Compare
|
PR updated |
VinceMacBuche
force-pushed
the
ust_7375/add_an_option_in_the_web_interface_to_completely_disable_reporting
branch
2 times, most recently
from
84bd20c
to
d6a4765
Compare
|
PR updated |
| @@ -12,7 +12,11 @@ | |||
| network traffic, but provides more precise reporting and may be necessary to prove compliance in your organization.<br/> | |||
| In <b>Changes only</b> mode, reports will only be sent when the agent makes a change or an error occurs on a node | |||
| (these are 'repair' or 'error' reports). This mode saves a lot of log space and bandwidth, but leads to some assumptions | |||
| about actual configuration status in reporting. | |||
| about actual configuration status in reporting.<br/> | |||
| In <b>Disabled</b>b> mode, no reports will be sent, and rudder-agent will not re-configure the local syslog to send reports. | |||
There was a problem hiding this comment.
There is a b> that should not be here
|
PR updated |
VinceMacBuche
force-pushed
the
ust_7375/add_an_option_in_the_web_interface_to_completely_disable_reporting
branch
from
d6a4765
to
bfdb3e2
Compare
|
PR updated |
VinceMacBuche
force-pushed
the
ust_7375/add_an_option_in_the_web_interface_to_completely_disable_reporting
branch
from
bfdb3e2
to
86b01b0
Compare
|
PR updated |
VinceMacBuche
force-pushed
the
ust_7375/add_an_option_in_the_web_interface_to_completely_disable_reporting
branch
from
86b01b0
to
2b46102
Compare
fanf
added a commit
that referenced
this pull request
Nov 13, 2015
…the_web_interface_to_completely_disable_reporting Fixes #7375: Add an option in the web interface to completely disable reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7375