Fixes #7398: Update compliance UI to manage disable mode #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
ust_7398/update_compliance_ui_to_manage_disable_mode
branch
3 times, most recently
from
9c61301
to
9a41658
Compare
| @@ -304,7 +304,7 @@ case object LongComparator extends CriterionType { | |||
|
|
|||
| case object MemoryComparator extends CriterionType { | |||
| override val comparators = OrderedComparators.comparators | |||
| override protected def validateSubCase(v:String,comparator:CriterionComparator) = try { | |||
| override protected def validateSubCase(v:String,comparator:CriterionComparator) = { | |||
There was a problem hiding this comment.
shouldn't you keep the try ?
What happens if the parse fails ?
There was a problem hiding this comment.
then why not adding a catch ??
There was a problem hiding this comment.
because it is not supposed to throw exception (Full/Failure), the try must be a remeniscience of the past
fanf
force-pushed
the
ust_7398/update_compliance_ui_to_manage_disable_mode
branch
from
9a41658
to
02262d4
Compare
|
PR updated |
|
|
||
| val complianceWithoutPending = pc_for(success+repaired+notApplicable, total-pending) | ||
| val complianceWithoutPending = pc_for(success+repaired+notApplicable, total-pending-reportsDisabled) |
There was a problem hiding this comment.
Ha, shouldn't you remove the reportsDisabled on the left side as well ?
|
Thank you @fanf |
ncharles
added a commit
that referenced
this pull request
Nov 16, 2015
…nage_disable_mode Fixes #7398: Update compliance UI to manage disable mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7398