Fixes #7416: Compliance detail and compliance summary use different colours #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,7 +113,7 @@ $scope.columnDefs = [ | |||
| , 'bSortable': false | |||
| , "sWidth": "10%" | |||
| , "fnCreatedCell" : function (nTd, sData, oData, iRow, iCol) { | |||
| var color = sData ? "#CCFFCC" : "#FF6655"; | |||
| var color = sData ? "#5cb85c" : "#d9534f"; | |||
There was a problem hiding this comment.
I changed the colour here too, even though it's not related to compliance, because it was the same green, and it's better to be consistent across the whole UI.
fanf
added a commit
that referenced
this pull request
Nov 19, 2015
…_compliance_summary_use_different_colours Fixes #7416: Compliance detail and compliance summary use different colours
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7416