Fixes #7566: Create a test on promise write to check template filling #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
arch_7566/create_a_test_on_promise_write_to_check_template_filling
branch
from
f793178
to
3d010af
Compare
| // , SystemVariableSpec("RUDDER_NODE_GROUPS" , "The array of group_UUID => group_NAME for the node, in a formatted string" | ||
| // , multivalued = false | ||
| // , isUniqueVariable = true | ||
| // ) |
There was a problem hiding this comment.
ah, you're right, they should not be here.
fanf
force-pushed
the
arch_7566/create_a_test_on_promise_write_to_check_template_filling
branch
from
3d010af
to
e63d9a7
Compare
| @@ -210,6 +210,10 @@ class SystemVariableSpecServiceImpl extends SystemVariableSpecService { | |||
| , multivalued = false | |||
| , isUniqueVariable = true | |||
| ) | |||
| // , SystemVariableSpec("RUDDER_NODE_GROUPS" , "The array of group_UUID => group_NAME for the node, in a formatted string" | |||
There was a problem hiding this comment.
This needs to be added in anothe PR (but since it's commented it's not that important ...)
Just dead code until next PR
fanf
force-pushed
the
arch_7566/create_a_test_on_promise_write_to_check_template_filling
branch
from
e63d9a7
to
05e1732
Compare
|
A little pull request, I expect at least one per week like that :) |
|
mergin |
VinceMacBuche
added a commit
that referenced
this pull request
Dec 10, 2015
…write_to_check_template_filling Fixes #7566: Create a test on promise write to check template filling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7566