-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splits feature_combinations into multiple functions #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarized
feature_combinations
into two new functions calledfeature_exact
andfeature_not_exact
. All the functions are stored inR/features.R
observation_weights
since it is not used anywhere in the codebase. The function was previously stored inR/shapley.R
.shapley_weigths
so that it handle cases with zero features and m features, i.e. wheres = 0
ors = m
.sampling_features_cpp
. This part will only be used ifexact = FALSE
infeature_combinations()
.R/features.R
. Seetests/testthat/test-features.R
.Fixes #71 and #72. These issues came up when writing the tests.
Benchmarks
Ran the following chunk using the version from
master
andnikolai/tests_features
Current
Master