meta: Fix even fewer object creations #1165
Conversation
jani270
changed the title
There was a problem hiding this comment.
I am going to be honest, a lot of these "performance improvements" as of lately seem to be very misguided. I urge you to think about your code instead of blindly "optimizing" whatever statistic your new fancy profiler shows you. A lot of your performance improvements either break features, are shoddily implemented (some more complicated stuff like bad memoizations, relatively expensive hash functions, insufficient cache eviction, but also including simple typos!!!), or even make performance worse. I don't think I want to list all the minor details out here, all three of your PRs would be quicker to be done completely over with, rather than fixing your PR up.
| String rawName = entity.getName(); | ||
| IChatComponent name = Utils.getOrPut(nameCache, rawName, entity::getDisplayName); | ||
| if (!entity.hasCustomName()) return name; |
There was a problem hiding this comment.
Fairly sure this will just create more performance issues? It will increase RAM usage and it will decrease raw CPU performance.
There was a problem hiding this comment.
fair point.
Should we rather avoid touching IChatComponent here then? as this still creates new objects on every call, filling up the gc quickly.
then please do so, or suggest better solutions. |
This PR depends on:
Avoiding creating new objects even more often.