-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#429 Migrate to turbo and pnpm #461
Open
FranciscoMoretti
wants to merge
34
commits into
NotionX:master
Choose a base branch
from
FranciscoMoretti:migrate-to-turbo-and-pnpm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#429 Migrate to turbo and pnpm #461
FranciscoMoretti
wants to merge
34
commits into
NotionX:master
from
FranciscoMoretti:migrate-to-turbo-and-pnpm
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Feedback is encouraged. I had to make a few choices here and there and I'm unsure if they are the best. Also, it seems like deployments are failing and I can't inspect or check details. @transitive-bullshit let me know if there is anything I can do to fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
Lerna
andYarn
withTurbo
andPnpm
.Changes:
tsup
and lesstsc
tsup
is the recommended tool inturbo
docstsup --watch
replaces all thewatch
tasks. It automatically re-builds a package when in development tasks. Docstsup
now generates the type definitions with the configdts: true
ontsup.config.ts
Docscomposite
is not supported bytsup
, so I've changed it tofalse
DTS error withcomposite
egoist/tsup#571.turbo
docs"workspace:*"
. They should get replaced by the actual version when publishing Pnpm workspaces.turbo
tasks docsturbo
linting docsturbo.json
)package.json
turbo.json
.deploy
task tovercel-deploy
in examples to avoid confusion withpnpm deploy
pnpm vercel-deploy
andpnpm run vercel-deploy
are valid from an example directorydeploy
name but that would only work withpnpm run deploy
becausepnpm deploy
is an existent pnpm command.turbo
caching.Benefits
This change has the following advantages:
dev
with a single commandTurbo Examples
The configuration was inspired by Turborepo official examples
Basic example: https://github.com/vercel/turbo/tree/main/examples/basic
CRA example: https://github.com/vercel/turbo/tree/main/examples/with-create-react-app
Kitchen sink example; https://github.com/vercel/turbo/tree/main/examples/kitchen-sink
This bugfix was needed for a correct build of
notion-x-example-full
handle possible NotionCompatAPI without search #459Tests
[x] Installing
[x] Running a global build:
[x] Running a build from the package dir
[x] Running every dev task
[x] Running tests execute
unit
eslint
andprettier
.[x] Running dev in a single example, modifying a dependency, and verifying it rebuilds it
[x] Connecting with
nextjs-notion-starter-kit
.yarn
link and the contributing docs from that repo are still valid after this change https://github.com/transitive-bullshit/nextjs-notion-starter-kit/blob/main/contributing.md[x] Running publish executed the correct tasks
[x] Running vercel deploy
[x] The cache works as expected in all tasks