[MIRROR] Virtual Domains now have certain areas protected from ghost role interference #2353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#82960
About The Pull Request
This touches up on the bitrunning ghost roles that come with some maps, namely Corsair Cove and Syndicate Assault.
The gist of it is: Ghost role spawners and Digital Anomalies (the random event boss mobs) are now restricted from entering the VDOM safehouse, and other areas where critical equipment is stored.
Here's an example from Syndicate Assault -- The X-ed out area is considered "out of bounds" for digital anomalies/ghost roles:
Additionally, this also fixes the matter of pirate ghost role spawns creating their own antag datum/pirate team, which would carry into the roundend report. Since these are no longer legitimate pirate spawners and are now specifically designed spawners for virtual domains.
Naturally, emagging the server jailbreaks all of these restrictions and notifies any virtual entities.
The new subtype of spawners should also be scalable enough that new VDOMs should be able to implement new ghost role spawners with ease.
Why It's Good For The Game
It's one thing to have sentient mobs to fight, which can shake up the otherwise somewhat static nature of bitrunning maps, but when players are tossing equipment, spawncamping, or otherwise making it impossible for the runners to fight them it ends up being unfun for everyone involved. You can't get into a good fight with a bitrunner avatar if their only recourse is to wipe the map and everything (YOU) in it.
This ensures a level of fairness between the (typically vindictive) ghost roles of a VDOM and the players.
Also, pirate spawns don't make a new pirate team/datum. That's one of the fixes I was aiming for with this.
Changelog
🆑 Rhials
balance: Virtual domain ghost roles can no longer enter the safehouse/"equipment" areas of a domain.
fix: Pirate virtual domain ghost roles will no longer make a pirate team antag datum.
/:cl: