Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Virtual Domains now have certain areas protected from ghost role interference #2353

Merged
merged 2 commits into from
May 7, 2024

Conversation

NovaBot13
Copy link
Collaborator

Original PR: tgstation/tgstation#82960

About The Pull Request

This touches up on the bitrunning ghost roles that come with some maps, namely Corsair Cove and Syndicate Assault.

The gist of it is: Ghost role spawners and Digital Anomalies (the random event boss mobs) are now restricted from entering the VDOM safehouse, and other areas where critical equipment is stored.

Here's an example from Syndicate Assault -- The X-ed out area is considered "out of bounds" for digital anomalies/ghost roles:
image

Additionally, this also fixes the matter of pirate ghost role spawns creating their own antag datum/pirate team, which would carry into the roundend report. Since these are no longer legitimate pirate spawners and are now specifically designed spawners for virtual domains.

Naturally, emagging the server jailbreaks all of these restrictions and notifies any virtual entities.

The new subtype of spawners should also be scalable enough that new VDOMs should be able to implement new ghost role spawners with ease.

Why It's Good For The Game

It's one thing to have sentient mobs to fight, which can shake up the otherwise somewhat static nature of bitrunning maps, but when players are tossing equipment, spawncamping, or otherwise making it impossible for the runners to fight them it ends up being unfun for everyone involved. You can't get into a good fight with a bitrunner avatar if their only recourse is to wipe the map and everything (YOU) in it.

This ensures a level of fairness between the (typically vindictive) ghost roles of a VDOM and the players.

Also, pirate spawns don't make a new pirate team/datum. That's one of the fixes I was aiming for with this.

Changelog

🆑 Rhials
balance: Virtual domain ghost roles can no longer enter the safehouse/"equipment" areas of a domain.
fix: Pirate virtual domain ghost roles will no longer make a pirate team antag datum.
/:cl:

@NovaBot13 NovaBot13 added Balance Changes to functionality that modifies how effective certain methods are at powergaming Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. labels May 7, 2024
@vinylspiders vinylspiders enabled auto-merge (squash) May 7, 2024 18:36
@vinylspiders vinylspiders merged commit c518daa into master May 7, 2024
21 checks passed
@vinylspiders vinylspiders deleted the upstream-merge-82960 branch May 7, 2024 18:43
NovaBot13 added a commit that referenced this pull request May 7, 2024
github-actions bot added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants