Virtual Domains now have certain areas protected from ghost role interference #82960
Conversation
readds the spawners under a new subtype all vdom entities (so, spawner ghostroles AND digital anomalies from the event) get their own trait that will be used for restricting the level of trolling/spawncamping they can do I dont think the ghostrole notif works rn but im not sure I cant seem to open my prefs on local??
this throws in the psyker zombie mystery box area too in addition to the other 2 main maps
Rhials
requested review from
EOBGames,
Maurukas,
MMMiracles,
san7890 and
ShizCalev
as code owners
tgstation-server
added
Balance
|
This should also close #80167, as the virtual syndicate outfit isn't given a headset (although I think this was solved by another PR already?) |
|
Small problem, this interferes with emagged servers/digital anomalies leaving the VDOM. I'll cook up a solution in a bit but it should be good to merge after. |
Good thinking. Imo this might be a good time to give screen alerts to the virtual entities that the server has been emagged. Delete the component thereafter? |
|
Should be ready now. I implemented a to_chat but not a screen alert, which gets sent to entities both when the server is emagged and when they spawn after the server has been emagged. Also, completely unrelated to what was worked on here, I discovered #82973. Human mobs really don't like leaving the simulation I guess. |
wait what, they can leave?? wtf does the emagged server even do? i didnt know you could emag them |
yes, you can see when a server is emagged by its blinking red light the idea is that bitrunners are weak and have to call upon their digital friends to do their dirty work, which are disloyal and dangerous, possibly killing them in the process |
|
New solution works and routes through on_threat_created. I'm leaving this as a draft for the time being because I would like to add a bitrunning glitch antag datum antag datum type for them so ghost roles aren't lumped in with the "alive" crew tab. |
|
This pull request was test merged in 8 round(s). |
About The Pull Request
This touches up on the bitrunning ghost roles that come with some maps, namely Corsair Cove and Syndicate Assault.
The gist of it is: Ghost role spawners and Digital Anomalies (the random event boss mobs) are now restricted from entering the VDOM safehouse, and other areas where critical equipment is stored.
Here's an example from Syndicate Assault -- The X-ed out area is considered "out of bounds" for digital anomalies/ghost roles:
Additionally, this also fixes the matter of pirate ghost role spawns creating their own antag datum/pirate team, which would carry into the roundend report. Since these are no longer legitimate pirate spawners and are now specifically designed spawners for virtual domains.
Naturally, emagging the server jailbreaks all of these restrictions and notifies any virtual entities.
The new subtype of spawners should also be scalable enough that new VDOMs should be able to implement new ghost role spawners with ease.
Why It's Good For The Game
It's one thing to have sentient mobs to fight, which can shake up the otherwise somewhat static nature of bitrunning maps, but when players are tossing equipment, spawncamping, or otherwise making it impossible for the runners to fight them it ends up being unfun for everyone involved. You can't get into a good fight with a bitrunner avatar if their only recourse is to wipe the map and everything (YOU) in it.
This ensures a level of fairness between the (typically vindictive) ghost roles of a VDOM and the players.
Also, pirate spawns don't make a new pirate team/datum. That's one of the fixes I was aiming for with this.
Changelog
馃啈 Rhials
balance: Virtual domain ghost roles can no longer enter the safehouse/"equipment" areas of a domain.
fix: Pirate virtual domain ghost roles will no longer make a pirate team antag datum.
/:cl: