New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile errors not being handled correctly in build algo #68

Merged

Novacer merged 2 commits into master from fix-compile-error

Oct 21, 2019

Owner

Novacer commented Oct 21, 2019

Previously,

FE does not do error checking for if user code execution failed, and always keeps the spinner on.
Error msgs that contain characters like " don't get sent to the web socket server at all. This is pretty common in compile errors

Now,

FE will handle by closing websocket and stopping spinner, so user has visual indication that code execution has failed
Error msgs are now formatted so there are no more issues with character escaping and such.

Novacer added 2 commits

October 20, 2019 22:25


          Added error handling for compile errors and fix issue with error msgs…

c429d79

… not displayed in logs


          close ws connection on fail

78b8c20

Novacer merged commit 03d9fcf into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet